search

bitfireAT / vcard4android

Allows usage of vCard resources with the Android contacts provider
GNU General Public License v3.0
11 stars 6 forks source link

Get rid of Apache Commons #41

Closed ArnyminerZ closed 3 months ago

ArnyminerZ commented 3 months ago

@rfc2822 I've turned Contact into a data class for the toString method, but now that it's a data class, do we want to keep using vars, or maybe it's better to use the copy method? I don't know how many replacements that would be. In that sense, if we make all variables inmutable, we should also make the lists non-mutable as well, so I don't know if we would want that now.

rfc2822 commented 3 months ago

Making ical4android and vcard4android data classes immutable is a good idea and on the plan for "somewhen" ;) But I think it's enough for now if they become data classes with var without further changes. However using data classes allows us to get rid of the reflection toString calls.