search

bitfireAT / vcard4android

Allows usage of vCard resources with the Android contacts provider
GNU General Public License v3.0
11 stars 6 forks source link

8 support IS_READ_ONLY for Data and Group rows (closes bitfireAT/vcard4android#8) #9

Closed sunkup closed 2 years ago

sunkup commented 2 years ago

Regarding the tests:

There is a AndroidGroupTest class, where we could put a testAdd_readOnly test that checks whether the read-only flag is set

For the more important data rows: my suggestion is to just test newDataRow in DataBuilder. So we could create a TestDataRowBuilder that extends DataRowBuilder and whose build() just returns one data row created by newDataRow(). The test could then check if the data row returned by build() contains the correct read-only column (2 cases).

Good thinking. I implemented the requested changes :)