search

bitfocus / companion-module-allenheath-sq

MIT License
11 stars 3 forks source link

Version 1.3.7 #24

Closed maxks closed 3 years ago

krocheck commented 3 years ago

@maxks frankly, this change makes no sense because config is always going to be passed to the upgrade, so you're checking for something that's (hopefully) always going to exist. It would be better to use your inline logic conditionals as if statements and then mark changed as true if you make a change.

maxks commented 3 years ago

@krocheck I using that condition because Julian wrote me this:

"@maxks in the upgradeScript config can sometimes be null, so you need to null check it first"

So I thought that if config exist and varaibles were set, the changes value is always true.

krocheck commented 3 years ago

Oh yeah ... forgot about that aspect of how the scripts execution changed. Ignore me