Scene-manipulation actions don't work if the mixer isn't set to use MIDI channel 1

bitfocus / companion-module-allenheath-sq

MIT License

7 stars 3 forks source link

Scene-manipulation actions don't work if the mixer isn't set to use MIDI channel 1 #56

Closed jswalden closed 1 month ago

jswalden commented 1 month ago

I've been fooling around in module code (mostly refactoring it to make it understandable to me) and happened to run across this bug. I have no idea if/when my fooling around will be complete enough to land (let alone whether it would be accepted), so I might as well save people from this bug before then.

josephdadams commented 1 month ago

I’m ok with any refactoring that makes it more maintainable because it’s awful right now. And the original author has abandoned it. I’d like to get this in great working order to then possibly apply the structure to the QU.

jswalden commented 1 month ago

Sounds good. I'll start getting them out the door once this is in -- starting with "autoformat all the code and enforce it on commit", which obviously is an implicit dependency of everything else.