bitfocus / companion-module-behringer-wing

MIT License
5 stars 7 forks source link

Simplify subscription to OSC by using *S (vs. *s) #14

Closed pmaillot closed 1 year ago

pmaillot commented 2 years ago

(Note really an issue, but here goes...)

In the function below:

instance.prototype.pulse = function () { var self = this; self.sendOSC("/*s", []); .....

You could use S instead of s and receive a single OSC value rather than 3; This would certainly help in simplifying some of the functions, including fader level values that you would always receive (and send) in dB, avoiding the need for dB2float and float2dB.

Also glad to see the documentation I wrote has been useful :)

-Patrick-Gilles Maillot

istnv commented 2 years ago

@pmaillot Your docs have been extremely helpful! Thank you! Internally, the module keeps track of fader position, not value. The float values from the console are the best source for this. The module has an increment/decrement fader by a 'tick'. Not every float translates, though. Early versions of the module, you bump up 5, then bump down 5, and not end up back where you started. Specially when crossing between slope boundaries. Internally the module generates an array equivalent of the float to db table from your docs. The bump up and down actions then walk this array. The only times the float conversions are actively used used is during a timed fade to keep the db variables updated.

pmaillot commented 2 years ago

John,

Thx,

That’s why I though using the *S would be helpful, especially for levels; Fader values are directly reported as dB, which are great for inc. or dec. 3dB (or 5) and keep track of fader position. No need to bother with a 1540 table of approximate float values, and even for cross fades, using a dB-based crossing function is more convenient from an auditive point of view.

-Patrick

From: John Knight Jr @.> Sent: Monday, April 25, 2022 2:45 PM To: bitfocus/companion-module-behringer-wing @.> Cc: Patrick-Gilles Maillot @.>; Mention @.> Subject: Re: [bitfocus/companion-module-behringer-wing] Simplify subscription to OSC by using S (vs. s) (Issue #14)

@pmaillot https://github.com/pmaillot Your docs have been extremely helpful! Thank you! Internally, the module keeps track of fader position, not value. The float values from the console are the best source for this. The module has an increment/decrement fader by a 'tick'. Not every float translates, though. Early versions of the module, you bump up 5, then bump down 5, and not end up back where you started. Specially when crossing between slope boundaries. Internally the module generates an array equivalent of the float to db table from your docs. The bump up and down actions then walk this array. The only times the float conversions are actively used used is during a timed fade to keep the db variables updated.

— Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-behringer-wing/issues/14#issuecomment-1108523496 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZZT7VRGPEHBDD3I6HU3E3VG2HWBANCNFSM5UHTBPUA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ADZZT7SXZHQNGRQXQM4FRSTVG2HWBA5CNFSM5UHTBPUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIIJLT2A.gif Message ID: @. @.> >

istnv commented 2 years ago

It is also the same cross fade logic I use in the XAir module which only has float, so this saves me from 2 different routines. The table is small, self generated and math is something the computer is good at. :)

pmaillot commented 2 years ago

OK then 😊

-Patrick

From: John Knight Jr @.> Sent: Monday, April 25, 2022 5:16 PM To: bitfocus/companion-module-behringer-wing @.> Cc: Patrick-Gilles Maillot @.>; Mention @.> Subject: Re: [bitfocus/companion-module-behringer-wing] Simplify subscription to OSC by using S (vs. s) (Issue #14)

It is also the same cross fade logic I use in the XAir module which only has float, so this saves me from 2 different routines. The table is small, self generated and math is something the computer is good at. :)

— Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-behringer-wing/issues/14#issuecomment-1108708462 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZZT7TJAGHI6FZO57VFBL3VG2ZJ7ANCNFSM5UHTBPUA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ADZZT7VNT6SPIVG23LCTXJLVG2ZJ7A5CNFSM5UHTBPUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIIKYY3Q.gif Message ID: @. @.> >