search

bitfocus / companion-module-bmd-atem

MIT License
54 stars 32 forks source link

fix: Improve logic for Increment Iris & Exposure #297

Closed NoahCallaway closed 4 months ago

NoahCallaway commented 4 months ago

Changes:

Fix lens iris adjustment by using fStop value not normalised. The comment here led me to believe the iris value in state was normalised. When incrementing smaller iris values I found this wasn't the case as the changes weren't applying.

Improve logic for incrementing shutter speed The previous implementation resulted in some incompatible shutter speeds e.g. 1/1. The ATEM seemed to do its best in translating this to a valid shutter speed but shows an incorrect value in software control. The new logic steps through a list of valid shutter speeds supported by ATEM software control.

Screenshot 2024-04-22 at 11 06 23

Testing

https://github.com/bitfocus/companion-module-bmd-atem/assets/24882928/a6c8e869-7014-4f90-bb41-73cef3cfd25a https://github.com/bitfocus/companion-module-bmd-atem/assets/24882928/436d1934-23bb-40c8-8e7a-266bba8fac5a
NoahCallaway commented 4 months ago

@Julusian - would it be possible to get this in ahead of the 3.3 release?

Appreciate you may want to batch this up with some other changes too.