search

bitfocus / companion-module-bmd-atem

MIT License
54 stars 32 forks source link

feat(camera_control): Add continuous zoom support #298

Closed johnsudaar closed 4 months ago

johnsudaar commented 4 months ago

Related to #288

I'm not found of the setTimeout in the code. But it doesn't look like the ATEM support a relative input. So this is a hack to make it work.

If there is a better way I would love implementing it.

Note: This requires https://github.com/Julusian/atem-connection-camera-control/pull/3 to be merged and released first.

Julusian commented 4 months ago

Rather than a setTimeout, I think it would be better to make this action simply be a 'set zoom speed' and require the user to do a second action to set the speed to 0 when they want. Either way, I think that separate action will be wanted anyway, it would let you do some nice things such as zooming while a button is held, or could be setup to do a nudge like this

johnsudaar commented 4 months ago

Indeed i think that a set zoom speed could be a good idea ! I'll add it. My goal was to make a rotary button work for the zoom hence the setTimeout but now that i'm thinking about it this can be done via companion directly by adding 2 actions and a delay between the two.

I think that we could just implement the setZoomSpeed action without the timeout WDYT ?

Julusian commented 4 months ago

I think that we could just implement the setZoomSpeed action without the timeout WDYT ?

Yes I think so.