search

bitfocus / companion-module-canon-ptz

MIT License
9 stars 6 forks source link

Variables not correct #30

Open justinjansen opened 10 months ago

justinjansen commented 10 months ago

When using the gain up or down (and other manual adjust settings), it seems the underlying code is assuming the current variable for gain is correct, when in fact, it may have changed due to a preset. Seems if there is not an up or down in the xc protocol that it should get the current gain before incrementing and sending it back. I've noticed this with several of the status variables that they don't update when a preset is recalled, and then adjustment buttons set it back it companion's last known state, which has been overwritten by something. Maybe the easiest fix is to update variables when a preset is recalled.

josephdadams commented 10 months ago

Feel free to submit an update to fix it

justinjansen commented 9 months ago

I'm an embedded C guy, and don't have any experience on companion modules or js, but I'm willing to dig in on my free time. Just curious if you had any thoughts on how best to fix it.

josephdadams commented 9 months ago

If you enable polling on the module, it should be grabbing the latest data pretty often from the camera.

richardgatarski commented 8 months ago

I've noticed that $(CAM1:rGainValue) and $(CAM1:bGainValue) are always 0, even when the N300 is in Manual mode.

(I'm not a programmer, so sorry can't update. But perhaps useful feedback for future devs).

josephdadams commented 8 months ago

I've noticed that Canon's implementation of their own protocol seems to vary from model to model. :) So what worked for a N700 might not work for an N300.

richardgatarski commented 8 months ago

bummer... But thanks for the explanation.