search

bitfocus / companion-module-canon-ptz

MIT License
11 stars 7 forks source link

Power toggle #5

Closed davidjoshuaford closed 2 years ago

davidjoshuaford commented 2 years ago

Hi Joseph, it appears that the toggle power function is turning the camera off, but does not turn it back on. The Turn On Power command functions correctly.

josephdadams commented 2 years ago

Sorry about that. I couldn’t test this at the time. I’ll try to debug it when I get a chance.

davidjoshuaford commented 2 years ago

All good, thanks! :)

josephdadams commented 2 years ago

It's because of this silly mistake on my part: https://github.com/bitfocus/companion-module-canon-ptz/blob/aedb29a12fcb9a45a673a6a99d5ac46dec865a46/src/actions.js#L174

josephdadams commented 2 years ago

Fixed, tagged, and released into core

davidjoshuaford commented 2 years ago

Thanks Joseph!

The last preset feedback is working well. I reduced the camera polling number from 5000 down to 500 to speed up the change.

Having trouble getting consistent preview tally lamps. Program on/off works consistently with the module settings. I've built a trigger to change the tally lamp to green when the PTZ's input is selected on the ATEM's Preview. The camera's green preview tally lamp turns on when pushed to Preview, and goes red when cut to Program. But... when cutting back, the lamp turns off altogether. Plus, in layering up feedback states on a button to show either preview or program, the preview feedback often remains on, even when it should be off. All this to say, is it possible to add a Preview tally function into the module configurations (like you have with the "Enable Tally On - Set camera tally ON when the instance variable equals the value" section). I think where I'm getting stuck is that setting turns the global tally ON/OFF, but the tally actions and feedback target specific program/preview tally lamp states.

Just a thought, hope that's not too convoluted! (The benefit here is a cam assistant would be able to chase the preview tally lamp to select or fine tune PTZ angles before they are cut live). Thanks for your work!

davidjoshuaford commented 2 years ago

One more thing that may be a bug unless I'm mistaken – the Recall Preset Mode for Speed doesn't appear to work. Seems like it does work for "Time" and for "Normal", but not for "Speed".

josephdadams commented 2 years ago

Ok, I added the tally preview listener just like pgm listener. Please test and open a new issue if it is not working as expected. Please also file a new issue for the ptz speed recall problem so we can try to track that as well. Not sure I can fix it, but please describe steps and actions using.

davidjoshuaford commented 2 years ago

You are amazing, thanks Joseph!