search

bitfocus / companion-module-canon-ptz

MIT License
9 stars 6 forks source link

Green Preview Tally Lamp turns off after CUT operation #7

Closed davidjoshuaford closed 2 years ago

davidjoshuaford commented 2 years ago

Great work on the Preview Tally lamp!

It's mostly working, however I have noticed that the camera's Green tally lamp turns off under the following conditions:

-> when the camera source (ie PTZ1) is in Program, the camera's tally lamp is correctly illuminated RED. When the CUT operation swaps PTZ1 into the Preview monitor, the camera's tally lamp switches to GREEN momentarily, but then turns off altogether. The only way to get the lamp to show green again, is to put a different source (ie PTZ2) to Preview, and then put PTZ1 back into Preview – then the green tally lamp will turn back on on the camera itself.

josephdadams commented 2 years ago

My guess is that the "tally off" command turns off all the lamps and the commands are just arriving to the camera in that order. This may not be fixable with the current structure.

I could try for both tally pgm off and tally pvw off, checking to see if the other lamp should be on and sending an on command for that lamp, if you want.

davidjoshuaford commented 2 years ago

Sounds good - I'll defer to your knowledge of what's best!

josephdadams commented 2 years ago

Ok, I made these changes and put them into the core. You'll have to try those and let me know how it goes. v1.0.4 of this module.

davidjoshuaford commented 2 years ago

Will do, thanks Joseph