search

bitfocus / companion-module-cockos-reaper

MIT License
7 stars 6 forks source link

reaper: Change colors based on a custom OSC message not working as intended #14

Closed benwingrove closed 2 months ago

benwingrove commented 1 year ago

I have tried using the "reaper: Change colors based on a custom OSC message" feedback but no matter how I try formatting the message, message type and value I am getting no results. I have used several OSC Listeners and they are seeing the correct output from reaper, in this case "/track/1/solo) FLOAT(1)"

super-frais commented 8 months ago

Not working here either - here's how I got around it for the time being:

1) Created a custom variable on the button's $Variable tab to store the state of the Reaper target (in my case whether an FX is bypassed) 2) Companion can change its own custom variables via OSC (port 12321 by default) - from the docs:

  /custom-variable/<name>/value <value>
  Change custom variable value

...so I set a command in the Reaper OSC pattern file like so: 

  `FX_BYPASS b/custom-variable/bypass/value`

This updates my custom variable with the state of the FX bypass state.

3) Then - and this is the special sauce - I went into the Feedback tab for the button, and have it update the color based on the value of the custom variable (see attached picture). It's a little hack-y, but it does work.

feedback_tab

LykaiosNZ commented 8 months ago

From my testing it does work but I had to restart after adding the feedback as it only sets up handlers during initialization, give that a go.

super-frais commented 8 months ago

Yeah the standard feedback method definitely doesn't work here. This is after restarts, updating Companion version, etc. The above is the only way I am able to get it to work.

LykaiosNZ commented 8 months ago

I added this feedback to a button and restarted Companion and the button correctly changes colour when I toggle repeat on/off. I am using the default pattern.

image

I am working on migrating the module to support Companion 3.x and will fix feedbacks not being refreshed until restart as part of that.

Edit:

What are you trying to do that you need a custom message for? A bunch of my changes from a while back included a heap of track and track fx related feedbacks, these changes have been merged but a new version was not released. So if you are using Companion 3.x you could just clone down this repo and use the Developer Modules Path to use the unreleased version and see if that has a feedback for what you want.

Also if there is a particular feedback/variable/action that's not available please raise an issue so it can be added 🙏