bitfocus / companion-module-cockos-reaper

MIT License
7 stars 6 forks source link

Added feedbacks and presets #3

Closed odedd closed 4 years ago

odedd commented 4 years ago

I added:

I modified the "rewind" and "forward" behaviors so that it better suits how Reaper reacts to it: Reaper requires a /rewind with a numbered argument of 1 to start rewinding and an argument of 0 to stop rewinding. Same goes for forward. I therefore split the action to rewind (start) and rewind (stop) (same for forward). They should be used as key down and up actions respectively. I of course created presets with this behavior, as well as feedback to reflect the state.

Other than that, since the code became quite huge, I split it into several files as tidy as I could.

Here it is in action: Screen-Recording-2020-06-01-at-22 16 37

krocheck commented 4 years ago

My only note here is on the feedbacks. I'm not sure if you know you have the option to define callbacks for the processing instead of the big feedback function in index.js.

Here's an example. n.b. this module uses ES6 notation instead of Prototype. I couldn't think of an example in Prototype, unfortunately. Just giving the option if you want, otherwise this reads fine, though I need the version in package.json incremented. v1.1.0 seems appropriate given the changes here.

odedd commented 4 years ago

Great, I'll work on that and bump the version in package.json. I actually did stumble upon that option after finishing everything else. I'll see how to translate the callbacks to the feedback definitions themselves - that does sound more tidy.

odedd commented 4 years ago

done

krocheck commented 4 years ago

Tested?

odedd commented 4 years ago

Of course.