[REFACTOR] Combining colortemp actions

bitfocus / companion-module-elgato-keylight

Controls the Elgato Keylight and Ringlight family of devices

MIT License

3 stars 5 forks source link

Closed estilles closed 3 years ago

estilles commented 3 years ago

Combining the existing colortemp action with the new colortempk action (re: #4) as requested by @krocheck.

krocheck commented 3 years ago

So, interestingly, I test 4 values pre dropdown and post. 3 of the 4 properly 'converted' to dropdown values:

So not sure about the once that didn't convert, but thoughts otherwise @estilles ?

estilles commented 3 years ago

So not sure about the once that didn't convert, but thoughts otherwise @estilles ?

I'll check it out

estilles commented 3 years ago

Was able to replicate and found the issue. Submitting another PR to fix.

estilles commented 3 years ago

Summited PR #7 to fix