bitfocus / companion-module-elgato-keylight

Controls the Elgato Keylight and Ringlight family of devices
MIT License
3 stars 5 forks source link

Refactoring: ES6 rewrite #8

Closed estilles closed 3 years ago

estilles commented 3 years ago

Hey guys!

I noticed a trend within the Companion community/ecosystem towards a migration to ES6. I had some free time on my hands over the holidays, so I decided to take a stab at it.

My PR I intends to accomplish the following:

Let me know what you guys think.

krocheck commented 3 years ago

@estilles you think its ready?

estilles commented 3 years ago

@estilles you think its ready?

Yes. I've been testing it for the past couple of days and I think I've worked out all the kinks. :-)

JTF4 commented 3 years ago

@krocheck we could create a new branch and merge the PR with that one if you want testing to continue.

krocheck commented 3 years ago

No that's fine, I was seeing the bugfixes coming in here so I wanted to get a sense of where we were at. I think it looks go, so we can merge this in.