search

bitfocus / companion-module-elgato-keylight

Controls the Elgato Keylight and Ringlight family of devices
MIT License
3 stars 5 forks source link

Feedback/polling mode does not work correctly after upgrade without workaround #9

Open thomascantrellsea opened 3 years ago

thomascantrellsea commented 3 years ago

Feedback doesn't work for me when moving from a previous version of the Keylight module (from about 2 months ago / the version in 2.1.1) to the new one. Looks like the workaround is to go into the Keylight and:

Then it starts working, and I see three variables almost immediately populated below.

I guess it's a decision whether that workaround is sufficient or not, the ideal of course is to use the hooks for upgrading instances. But the workaround isn't that bad, and it's probably worth saying something for folks who started using Keylight on 2.1.1 and then upgraded to 2.2.0 (or beyond).

Ultimately, enjoy the new functionality in the module - just wanted to point out the upgrade behavior and the workaround after a bit of puzzlement on my part.

estilles commented 3 years ago

@thomascantrellsea ... you're absolutely right. I think a better solution would be to set the "Enable Polling?" default to false, that way users coming from v2.1.1 won't experience this issue.

thomascantrellsea commented 3 years ago

Johnny,

Thanks! That makes sense, don't opt folks into polling if they didn't use it before.

JTF4 commented 3 years ago

I don't know why there's a commit that says I reverted the changes, but the PR has been merged and should fix the issue for new users.