search

bitfocus / companion-module-figure53-qlab-advance

MIT License
3 stars 7 forks source link

Cannot get feedback from QLAB. #56

Closed Raiden38 closed 2 years ago

Raiden38 commented 2 years ago

Cannot get any feedback from Q-Lab. In companion, TCP is checked. In Q-Lab, OSC is set. I can send any commands from companion to qlab without any issue. Just cannot get any feedback. In connection, got ERROR instead of OK as soon as I enable TCP. Tried with Local IP, WIFI and Ethernet. Any ideas?

istnv commented 2 years ago

What is in the log? Make sure all filters are off to see everything. Hover over the 'ERROR' box, you should see a pop-up with more details.

Raiden38 commented 2 years ago

Thanks for the quick reply.. Here is a screenshot:

Capture d’écran, le 2022-06-03 à 20 06 40

And log show: 22.06.03 20:37:44 instance(Q-Lab): Error: OSC10.originalPacketRedirected is not a function

istnv commented 2 years ago

Looping in @Julusian. The QLab module has no OSC10 element so this error is coming from another module. The only module that has OSC10 is the EOS module, which needs to handle this error.

Raiden38 commented 2 years ago

Just FYI, I do have the ETC-EOS module installed. Connection show as OK. And didn't had any issue with it..

istnv commented 2 years ago

I do not use the EOS module so it hasn't been an issue. There seems to be some variable overlap with some cross-module interaction that should not occur. It is probably on the QLab side so I'll look into this soon.

krocheck commented 2 years ago

No, I think it’s on the EOS side because they modify the osc module that’s imported, which shouldn’t occur globally but definitely seems to be @SteveTherrien

Julusian commented 2 years ago

Thanks for the ping. A quick skim looks like etc-eos is patching the osc lib, but they are directly modifying the imported osc object mensing their changes will be leaking into any other usage of osc. I'll look into it more in the morning

Julusian commented 2 years ago

I think I've found the bug in the etc-eos modification of osc that is causing this. It looks like originalPacketRedirected was changed to originalReadPacket at some point, but one reference was missed.

Please try the latest beta build, I have fixed this typo there. Hopefully that will fix things well enough for now.

I have raised a PR to avoid leaking the modified osc lib, but I need that to be tested before merging, as it is likely to easily break etc-eos if I did something wrong https://github.com/bitfocus/companion-module-etc-eos/pull/15

Raiden38 commented 2 years ago

Hi @Julusian Thanks so much for the quick fix, so appreaciated!

Unfortunately, I am not sure where to put the new file. I am using the MAC (Intel) version of companion, witch normaly have a install package, so I am not sure where to put the individual files. I looked into the app content, made a search for index.js but could'nt find it. Where can I find more info on instaling that version for mac?

Thanks! :)

istnv commented 2 years ago

This was fixed, Closing.