bitfocus / companion-module-fora-hvs

MIT License
1 stars 5 forks source link

For-A Production Switcher Support #6

Closed TristanMoodley97 closed 4 years ago

TristanMoodley97 commented 4 years ago

Currently using a mixture of BlackMagic, Anologue way as well as a For-A HVS 2000. Having support for For-A would make life incredible. Much appreciated

josephdadams commented 4 years ago

@michaelallen any input here? Asking since you created the HVS 100 module.

MichaelAllen commented 4 years ago

It is possible that the 2000 uses the same websocket protocol as the 100. I saw several references to M/E 2 in the web interface script files I based my module code on, and the 100 only has 1 M/E.

@TristanMoodley97 What GUI software version is your switcher running? (Web interface > Setup > Status) If it is v1.10.0 there is a good chance that it is the exact same software as the 100, and that the HVS 100 module will work for you.

JeffreyDavidsz commented 4 years ago

Let me know then I can adjust module name before including it in the core

TristanMoodley97 commented 4 years ago

@MichaelAllen Stock 1.0

MichaelAllen commented 4 years ago

It still may be using the same protocol. It would be worth testing, at least. The module is not in any public builds yet, though. You would have to build your own version of companion from source to be able to test the module.

If that is more complicated than you want to get into, I can try to create a build and send it to you. Just let me know what OS you are running.

JeffreyDavidsz commented 4 years ago

@MichaelAllen I'am including it into core for you. can you check is your module can use websocket instead of ws? websocket is already in companion: https://www.npmjs.com/package/websocket. I'll do a namechange so you would need to pull first before making changes.

MichaelAllen commented 4 years ago

@JeffreyDavidsz Thank you. I will work on changing over to websocket this week.

MichaelAllen commented 4 years ago

@TristanMoodley97 My plugin is not working with the hvs2000 currently, but I am working on making it compatible.

I will try to remember to ping you here when the 2000 support is ready to test. You can also follow our progress in this issue.

josephdadams commented 4 years ago

I’m going to transfer this to the HVS module so you guys can track it there.

TristanMoodley97 commented 4 years ago

Silly question, but how would I go about importing this module ?

TristanMoodley97 commented 4 years ago

@josephdadams , actually, all I need to get it running is the skel module you are importing in the index.js file.

See: const instance_skel = require('../../instance_skel');

I have looked and it is not a npmjs.org public module I can install either - if it is referring a to a specific one i overlooked in npmjs.org, please include the dependency in the dependencies object in the package.json file.

JeffreyDavidsz commented 4 years ago

@TristanMoodley97 the instance_skel is the base for the modules. you cannot just include it somewhere else. I think your are trying the wrong thing. If you have a dev envoirement running, the module is already in there (if you are up-to-date). Follow the wiki for some instructions

MichaelAllen commented 4 years ago

@TristanMoodley97 that file is part of companion. To import this module into Companion, you would need to drop the module's code into lib/modules/fora-hvs folder.

However, that is no longer necessary because this module is now included in companion core, so you can just yarn update in the main companion folder to have it pulled in automatically.

MichaelAllen commented 4 years ago

Currently, the HVS-100 is working great, but HVS-2000 support is still a work in progress.

If you are able to help me get the 2000 working, that would be awesome. It is difficult since I don't have access to that model I am kind-of coding blind. (see https://github.com/bitfocus/companion-module-fora-hvs/issues/1#issuecomment-595853530 for where we are currently at with the 2000)

MichaelAllen commented 4 years ago

Support for the HVS 2000 is now available in the latest Companion v2.0 beta builds.