search

bitfocus / companion-module-generic-emberplus

Companion Module for the Ember Plus protocol
https://github.com/Lawo/ember-plus
MIT License
3 stars 6 forks source link

missing type int64 #5

Closed miambe closed 2 years ago

miambe commented 2 years ago

I successfully use the emberplus-console software to trigger a fader on my DHD.AUDIO console. Here is the command line used : EmberPlus-Console -w -n 172.30.22.3 "0.3.231.2/:1000"
EmberPlus-Console is available on https://github.com/LeeO86/EmberPlus-Console

If I check with Ember+ viewer, I can see the type is int64 and not int image As there is no integer64 option in Companion, I use "ember plus generic Set Value Integer" image And I'm getting this warning on log : image Same issue if I use "ember plus generic Set Value String" Could you implement int64 and allow minus values? As you can see, the fader accept a value between -16000 and 1000

Olivier

krocheck commented 2 years ago

@baltedewit will need to weigh in when available. I did some poking first in the upstream library which does not provide a distinction between Int and Int64. So I checked the original Ember+ library as well which doesn't seem to make that distinction either. And I would say its rather odd to use int64 for a range only requiring -16000 - 1000 as that fits easily into a standard int range of +/-32,768. So there might be something else going wrong here then a type not being supported.

mint-dewit commented 2 years ago

The specific warning you get is a bug that prevents the module from setting integers. It has been fixed in v1.1.2 of the module, I have asked companion maintainers to upgrade but it looks like that hasn't happened yet. @krocheck perhaps you can make this happen?

krocheck commented 2 years ago

Yeah, musta got lost in the shuffle. Done. Sorry

miambe commented 2 years ago

@baltedewit Thanks for the quick reply!!! @krocheck So I will wait companion-2.1.5-XXX-win64.exe and confirms.

krocheck commented 2 years ago

It is going into the latest beta, which you can download from the "Beta Builds" area of the Bitfocus website where you download Companion. If you want it in a stable release, you'll have to wait for v2.2.0

miambe commented 2 years ago

@krocheck I've installed the beta 2.2.0 and still the same warning message (and... no action ;) ).

mbaklor commented 2 years ago

Hi, I too installed 2.2.0 beta (whichever build was from today) and couldn't connect to the parameter with any of the types, and it worked from the ember+ viewer: image

Any idea where the problem is? Maybe what was in the beta isn't your most recent build from here?

mint-dewit commented 2 years ago

@mbaklor well, the "Int64" works fine with the Lawo software I can test with so I'm pretty sure it's not the parameter type itself that is the problem. If I can get access to the raw bytestream I can feed it into the decoder manually and probably figure out why it doesn't report to us as a known type. If you know how to send me a .pcap with just the ember+ traffic I"ll be happy to take a look at it.

mbaklor commented 2 years ago

A bit of light testing with wireshark later, it looks like only the first button press sends anything, and subsequent presses on any of the buttons I set up show up in the companion log but not in the wireshark. I'll send the capture as it is right now: a connection, one single correspondence and a bunch of keepalives, let me know if there's any more information you need. dhd-ember-capture.zip

mint-dewit commented 2 years ago

Thanks for sharing that, I can see what is wrong now. That node does not explicitly report its type as integer, instead it is inferred from the value. Support for this way of reporting types has been available in emberplus-connection for a while but I see companion is still using an older version that does not have this.

mbaklor commented 2 years ago

Update - everything works on my end with the latest release (2.2.0)