Closed llamafilm closed 2 years ago
@llamafilm / @krocheck Just pushed a fix that that will prevent that crash and instead will log the corresponding error. I'm not certain what's causing the underlying exception, except maybe the self-signed cert.
I'll push this change unto the Companion core, so it will be available on the next beta build. @llamafilm ... if there're still any problems please reopen this issue and let us know.
Thanks for fixing the crash. It would be great to handle bad SSL certificates too. I use several different softwares that offer a REST API using a self signed cert.
@llamafilm Can you tell me the specific error message that's logged? I'll try to reproduce on my end.
@llamafilm I was able to replicate your issue using https://self-signed.badssl.com/. I've submitted a PR for a potential fix. Let's wait for the team's acceptance/approval.
Wow that's a cool website! I tried your PR and it works for me.
Wow that's a cool website! I tried your PR and it works for me.
That was quick! What timezone are you in? :-)
I’m in LA. I just happened to be staring at my GitHub notifications when that came in :-)
As an experiment, I tried sending GET requests to a Supermicro IPMI server using this module. I was just trying to test the syntax for including a Basic Auth header, but I found that this crashes Companion every time. Example URL: https://10.49.54.201/redfish/v1/Systems/1/EthernetInterfaces/1
It uses a self-signed SSL certificate, could that be the problem? If I use http (no S) instead, the server responds with 301. If I try without the basic auth header, the server responds 401. In all cases it crashes in the same way. Nothing is written to the log, but I see this error in the shell:
Here is the same command from
curl
with a successful 200 response.I'm using version 2.2.0-4abb3e87-3673 on Ubuntu 20.04 headless. Other types of HTTP server work fine with this module.