bitfocus / companion-module-generic-osc

Companion Module
MIT License
3 stars 14 forks source link

Using OSC Custom Command - Variables are not parsed when sent out #23

Closed brianshaw closed 1 year ago

brianshaw commented 1 year ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

When using Bit Companion OSC Custom Command - the path doesn't parse variables and my OSC Server receives the $(internal:custom_somevar) as a string value.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: macOS Monterey 12.5.1
- Browser: Chrome latest
- Companion Version: latest

Additional context

No response

dnmeid commented 1 year ago

Please specify exactly which action you are refering to. Please specify the path string you want to be parsed, make sure that it is a valid path with a valid variable.

brianshaw commented 1 year ago

OSC / ISO module2: Join Meeting This is the log error from my OSC server

Error: failed to join meeting with id $(internal:custom_todaysMeeting) user testname pass $(internal:custom_todaysPassword) with error

I have confirmed the variable has data by using it within the button name and the correct value is shown on the button.

I also tried this in the OSC / ISO module2: Custom command and in the path i put the same variables and got a similar error

JeffreyDavidsz commented 1 year ago

@brianshaw I just added variable support to password and meetingID (it was only on name) 33c1c90 In the zoom-osc-iso module

JeffreyDavidsz commented 1 year ago

As @dnmeid requested the exact data you are using is crucial to see what is going on. I think you are using the zoom-osc-iso module and not the generic-osc module (where this issue is)? 'Bit Companion OSC Custom Command' Does not exist here. I'll close this issue. For reference; because of an other issue I've updated this module to also support objects (which you should use in this case because you would need to specify what the values are for)