search

bitfocus / companion-module-generic-osc

Companion Module
MIT License
3 stars 14 forks source link

Fix the truncating of OSC commands to 9 characters #6

Closed druidma closed 3 years ago

druidma commented 3 years ago

Hi there, I have altered the code to prevent OSC messages being truncated at 9 characters. For the moment I have commented out the width that was causing the issues.

krocheck commented 3 years ago

That input is used to define the CSS width of the IP field in the instance config screen. Definitely not a fix for what you're running into.

druidma commented 3 years ago

Hi Krocheck, I understand that is the intent of that input, however when I have tested it with that width expanded or removed the OSC message is no longer truncated. I will have a further look to see if I can work around it another way, but this input width change did fix the issue that I was seeing in my instance (running on a 2017 MacBook Pro with catalina)

druidma commented 3 years ago

Hi Krocheck, I understand that is the intent of that input, however when I have tested it with that width expanded or removed the OSC message is no longer truncated. I will have a further look to see if I can work around it another way, but this input width change did fix the issue that I was seeing in my instance (running on a 2017 MacBook Pro with catalina)

Apologies, this seems to be due to the particular side build.