search

bitfocus / companion-module-generic-pjlink

Companion Module
MIT License
6 stars 8 forks source link

feat: add variables & feedback #22

Closed jmcc94 closed 2 years ago

jmcc94 commented 2 years ago

Closes #12 / #20 / #21

josephdadams commented 2 years ago

@jmcc94 left one comment. Otherwise looks good to me!

istnv commented 2 years ago

You may as well add feedback and variable for the shutter while you're working on it :)

jmcc94 commented 2 years ago

@istnv - Feedback/Variables added for both Freeze & Mute

jmcc94 commented 2 years ago

Once you are happy, can this be merged? And then, the updated module go into beta..?

istnv commented 2 years ago

@jmcc94 I was going to work on this myself soon, which is why I suggested the other feedbacks. You've done more than I had planned and it looks good.

mabyoro commented 2 years ago

wow that is a really great Upgrade, thanks a lot! I totally agree @istnv that this is more than I had planned and it looks good!

With my Panasonic-Projectors (RZ31, RZ770, DZ21, RZ120) it looks like Mute and input is reversed... mute

jmcc94 commented 2 years ago

wow that is a really great Upgrade, thanks a lot! I totally agree @istnv that this is more than I had planned and it looks good!

With my Panasonic-Projectors (RZ31, RZ770, DZ21, RZ120) it looks like Mute and input is reversed... mute

fixed in #25