search

bitfocus / companion-module-generic-pjlink

Companion Module
MIT License
6 stars 8 forks source link

Add update config script to fix mute action #36

Closed istnv closed 2 years ago

istnv commented 2 years ago

Fixed on/off/toggle logic for mute. Added missing update config function. Fixes #35

jmcc94 commented 2 years ago

@istnv - Why are we toggling the mute state, when the protocol has 6 various states (though we were only using 4 of them);

Shouldn't we be enabling all choices?

istnv commented 2 years ago

@jmcc94 Mostly time. I was trying to implement a fix that at least restored the original modules function, which only had AV on/off. Probably 90% of the usage is for a commercial/church application where the audio function of the projector is not being used so muting audio did not seem as important. This way, the module has lots of improvements while still being compatible with prior operation. The individual mutes can always be added later.

@istnv - Why are we toggling the mute state, when the protocol has 6 various states (though we were only using 4 of them);

  • Video Mute On
  • Video Mute Off
  • Audio Mute On
  • Audio Mute Off
  • Video and audio mute On
  • Video and audio mute Off

Shouldn't we be enabling all choices?