search

bitfocus / companion-module-generic-pjlink

Companion Module
MIT License
6 stars 8 forks source link

Added video input select #8

Closed HiDefDan closed 4 years ago

HiDefDan commented 4 years ago

Tested on Panasonic RZ31k with security disabled. First timer for pull request - sorry if it's a mess. I am keen to learn

HiDefDan commented 4 years ago

It looks like you've added some actions double now (freeze for example), and missing the actual command in this pull request.

Oops! what a dumb thing to do...

I have edited the file and it should now be as I intended.

HiDefDan commented 4 years ago

This will populate the list with commands, but it will do nothing. You will need the actual command also like for example; case 'inputSelect': cmd = '%1????? ' + action.options.inputNum; break; In the list down your code

Sorry again. More haste less speed. I need to fully work out how to use git on the command line - keep getting my password refused so I’ve been working via web 🤦‍♂️

JeffreyDavidsz commented 4 years ago

Normally I use atom to push my commits into Companion, but always web to create a pull request. If your commit to the fork is good, the pull request will match that

HiDefDan commented 4 years ago

Thanks for the tips and your patience.

I will retest the code on a projector this morning to ensure that I am happy with it. I’ve been sat on it since last November meaning to get around to it - I probably should have spent another 24 hours making sure I was submitting it without stupid copy/paste errors 🙄

Sent from my iPhone

On 3 Mar 2020, at 21:32, Jeffrey Davidsz notifications@github.com wrote:

 Normally I use atom to push my commits into Companion, but always web to create a pull request. If your commit to the fork is good, the pull request will match that

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.