search

bitfocus / companion-module-getontime-ontime

MIT License
8 stars 5 forks source link

Convert module to typescript #14

Closed kellhogs closed 1 year ago

kellhogs commented 1 year ago

I've converted this module to typescript in preparation of the Ontime v2 api update

cpvalente commented 1 year ago

This looks good from app side, good work @josephdadams or @Julusian would you guys be available for some sanity check?

Also, is it possible to add collaborator permissions to @kellhogs , he is maintaining the module on its own at this moment

dnmeid commented 1 year ago

I guess you just did the change in source and then did not run yarn again. So currently yarn.lock still is pointing to base v1.4. The current beta has now been updated to base 1.4 too, so this won't be a problem any more for users running the very latest beta. Just tell me if you want it to be merged like this or if you want to sync yarn.lock with package.json before.

kellhogs commented 1 year ago

I've synced the yarn.lock and it qould be great if you could merge here. I think we dont need to create a new release here tho cause i've already finished the update for the V2 API update. Once you have merged i'll try to rule out any merge conflicts that might turn up and the post the next PR.

Looking out for what you have to say to it