search

bitfocus / companion-module-getontime-ontime

MIT License
8 stars 5 forks source link

Variables from OnTime #7

Closed tcconway closed 1 year ago

tcconway commented 2 years ago

Would like to request that the Companion module be able to get variables from Ontime. Things like:

This would be super helpful as we build out our Companion buttons! Thanks!

cpvalente commented 1 year ago

Hi @tcconway , have you got a chance to check the changes in the latest beta?

tcconway commented 1 year ago

Hi @cpvalente -- I'm running companion (3.0.0+5393-beta-c304f676), but don't see the variables @kellhogs mentioned...perhaps I'm running the wrong ver? Would I need to get beta code for this module directly? Thanks all!

kellhogs commented 1 year ago

Hey @tcconway, unfortunately my changes haven't been merged to the official repository yet. So to test the changes you would need to clone my repository (https://github.com/kellhogs/companion-module-getontime-ontime) and run it on a local development instance of companion.

I haven't gotten around to make the module v3 ready yet. Some features are working in v3 and some don't. So it would be best if you test it with the latest stable version of companion.

tcconway commented 1 year ago

Thanks @kellhogs for the clarification.

tcconway commented 1 year ago

Hey @kellhogs Any guestimation on when your updates will be included in the latest stable version of Companion? (Sorry - don't really know the process)

kellhogs commented 1 year ago

hey @tcconway sorry for the late answer.

The changes i made wont come to the latest stable version from companion scince they include the updates to Comapnion V3.

anyway this week my changes got merged to this repository and are now included in the current beta build of Companion.

Hope this helps.

josephdadams commented 1 year ago

@kellhogs can this be closed?

kellhogs commented 1 year ago

I've implemented the variables as requested by @tcconway

I would like to get feedback from @tcconway on the implementation before we close this.

cpvalente commented 1 year ago

Closing the issue as implemented. No more actionable points here

tcconway commented 1 year ago

Thanks for working on this! I do only see "undefined" variable data though.

cpvalente commented 1 year ago

Hi @tcconway, great to hear from you

There have been some braking changes in the API recently. With ontime 2.9.0 you need the module version 2.3.0

Do get in touch if you can't resolve this