[BUG] H2R Graphic plugin in Companion

Suenee commented 1 year ago

Is this a bug in companion itself or a module?

[X] I believe this to be a bug in companion

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

I have last version of H2R Graphic: v2.12.3 I created new LIST, so have LIST 1 and LIST 2. When I try to select source item of list, there is still possible to choice only LIST 1.

Steps To Reproduce

create LIST 2 in H2R Graphic
goto companion and try to select item from list 2

Expected Behavior

No response

Environment (please complete the following information)

- OS: Win7
- Browser: Chrome
- Companion Version: 2.4.1 (2.4.1+4899-09d279c6)

Additional context

No response

Suenee commented 1 year ago

I think the easiest way to fix this is to change the selection to input type=number. Currently, it is hard set that only "LIST 1" can be selected. Check out https://github.com/bitfocus/companion-module-h2r-graphics/blob/2809a2147bc18de5f907796576da63da66accb8a/src/actions.js#L916-L921

The processing of the action at https://github.com/bitfocus/companion-module-h2r-graphics/blob/2809a2147bc18de5f907796576da63da66accb8a/src/actions.js#L1368 is then fine.

Of course the ideal solution would be to retrieve from H2R what LISTS are available. I give the above idea as a quick fix. :-)

hdRunners commented 1 year ago

Thank you! I have also run into this bug. Btw, how do I tell companion to use the modified js file? Sorry I'm new.

iamjohnbarker commented 1 year ago

Fixing in the next version!

bitfocus / companion-module-h2r-graphics