search

bitfocus / companion-module-knx-ip

MIT License
0 stars 0 forks source link

KNX-IP - Module already implemented #1

Open MaZderMind opened 2 years ago

MaZderMind commented 2 years ago

Hi!

https://github.com/MaZderMind/companion-module-knxip

I've Implemented a Module for directly speaking KNX-IP. We use it with an MDT KNX-IP Gateway (although it should work with any KNX-IP Module) to control Lights (in 1bit and 2bit override mode), Blinds, Dimmers, Motorized Curtains etc.

I'm not that happy with the amount of "values"-Spam the Module leaves behind, because I can't change the Labels, Ranges, etc. on demand but only show/hide them with the isVisible-Function. That would be a Feature Request I'll open separately.

I'd be happy about feedback and code-review.

Thanks!

Screenshot 2022-05-17 at 08 52 55 Screenshot 2022-05-17 at 08 53 49 Screenshot 2022-05-17 at 08 52 39
josephdadams commented 2 years ago

@MaZderMind I will make an official Bitfocus repo for this and you can push your code there. Then we can start the process of getting it included.

MaZderMind commented 2 years ago

Perfect @josephdadams – should I push into a specific branch and open a PR against the empty master/main branch? That way we would have a place for Code Review & Discussion.

josephdadams commented 2 years ago

https://github.com/bitfocus/companion-module-knx-ip

You can just push to master and we can review it there.

MaZderMind commented 2 years ago

I force-pushed my main branch into that repo. I'll add README/Documentation as soon as I come around to it.

josephdadams commented 2 years ago

transferring this to that repo

MaZderMind commented 2 years ago

I added HELP.md and README.md and cleaned up the LICENSE.

bitte-ein-bit commented 1 year ago

@MaZderMind, is there anything missing? Judging from the date, I assume it’s incompatible with Companion 3 still?

MaZderMind commented 1 year ago

It is, but that is on my Worklist for this Month.Am 08.07.2023 um 19:14 schrieb Jonathan @.***>: @MaZderMind, is there anything missing? Judging from the date, I assume it’s incompatible with Companion 3 still?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Nordln commented 3 months ago

@MaZderMind Really like your KNX-IP module and I am very keen to put it to use in a work AV Studio. I am currently using Bitfocus companion 3.2.2. Your module seems to be stuck waiting for inclusion into the version 3 module repo. I am attempting to get a handle on building the module manually for my instance. Do you know if it's working with V3? Thanks, Nordin

josephdadams commented 3 months ago

6 appears to solve that

Nordln commented 3 months ago

6 appears to solve that

It does not appear to be visible using the in-app lookup on latest stable. Am I maybe missing something?

josephdadams commented 3 months ago

It hasn't been merged yet

Nordln commented 3 months ago

It hasn't been merged yet

Many thanks for the update.

In case anyone else landing here is as bad as me with node and wants to test this/develop this module presently, the following has worked out for me nicely: [I am using 3.3.0 (3.3.0+6855-main-547de31f) on Debian Bookworm, headless on a PI CM4 powered DeskPi Mini Cube.]

  1. Install node and yarn. I used fast node manager (fmn), selected node v18 as the default, and enabled corepack. 
    curl -fsSL https://fnm.vercel.app/install | bash
fnm install 18
fnm use 18
fnm default 18
corepack enable
  2. Git clone the companion3-compat branch into /opt/companion-module-dev on your box 
    git clone --single-branch --branch companion3-compat https://github.com/bitfocus/companion-module-knx-ip
  3. Install dependencies 
    npx yarn install
  4. Run yarn install
  5. Reload companion. The knx-ip connector is now selectable.

Some of the above steps may be unneeded, but it worked for me.