bitfocus / companion-module-lightware-lw3

MIT License
1 stars 3 forks source link

receive feedback not working #15

Closed kaibueden closed 6 months ago

kaibueden commented 1 year ago

error: received malformed connection status: CHG /MEDIA/XP/VIDEO.DestinationConnectionStatus=0;I2;I18;I18;I22;I22;I22;I24;I24;I17;I17;I18;I17;I5;I6;I1;I2;I14;I4;I7;I8;I6;I5;I4;

Companion 3.0.1 don't get any feedback of the Matrix via LW3.

JaaHann commented 6 months ago

Looks like the code doesn't take "unroutet" outputs into consideration when parsing messages.

if (inputs[0].match(/^I\d+$/)) (index.js, L832) This currently only checks for elements starting with an "I", followed by any number. To also check for empty outputs, it should additionally check for elements that are "0" within the regular expression. if (inputs[0].match(/^(I\d+|0)$/))

@kaibueden to resolve this issue for now, you could try to route any input to output 1 so it's not "0" and raising the error. @josephdadams (or any other contributor) could you please fix this directly? I'm not familiar with pull requests, unfortunately. Also in the config fields the "info" field has an invalid type of "text" instead of "static-text". Thanks a lot!

josephdadams commented 6 months ago

I have made the change you suggested and pushed that into v2.0.5