search

bitfocus / companion-module-liminalet-zoomosc

MIT License
7 stars 6 forks source link

feat: Allow use variables in "User Identifier" option #34

Open estilles opened 3 years ago

estilles commented 3 years ago

Resolves #33

@ashgreen / @yellowjaguar5 Now that bitfocus/companion#1755 has been merged into the Companion core, I'm submitting this PR to implement in your module.

image

gaetanfromdolive commented 2 years ago

Hello, (quite new to github, i hope i'm not making a mistake by commenting there and first of, thanks all of you for the beautifull work) @estilles could you share the modifications so i can try to build a version on my side ? it would be wonderfull if i can user this feature tommorow :) Regards Gaétan

ashgreen commented 2 years ago

@estilles Could you show me how you are using this in your workflow? I can see it would make it impossible to target someone with the username $(variable) unlikely I know, but still possible!

estilles commented 2 years ago

Hello, (quite new to github, i hope i'm not making a mistake by commenting there and first of, thanks all of you for the beautifull work) @estilles could you share the modifications so i can try to build a version on my side ? it would be wonderfull if i can user this feature tommorow :) Regards Gaétan

Hey @gaetanfromdolive! You can use the branch for this PR.

estilles commented 2 years ago

@estilles Could you show me how you are using this in your workflow? I can see it would make it impossible to target someone with the username $(variable) unlikely I know, but still possible!

I basically use it with ZoomISO to move assign/move participants to particular screens. Let's say, for example, I have 10 participants, 4 of which I can assign to specific screens. On the Stream Deck I would have 10 buttons, one for each participant, that will assign their name to a variable. Then I have 4 buttons (one corresponding to each screen) that will move the participant whose name is in the variable to that particular screen.

I'm sure there're many other use cases, but that's the one that prompted me to add this feature.

gaetanfromdolive commented 2 years ago

Hello, (quite new to github, i hope i'm not making a mistake by commenting there and first of, thanks all of you for the beautifull work) @estilles could you share the modifications so i can try to build a version on my side ? it would be wonderfull if i can user this feature tommorow :) Regards Gaétan

Hey @gaetanfromdolive! You can use the branch for this PR.

Thank you @estilles