search

bitfocus / companion-module-malighting-grandma2

grandMA2 support for companion
MIT License
12 stars 8 forks source link

Support for variables #10

Closed gerbenvandekraats closed 2 years ago

gerbenvandekraats commented 2 years ago

This adds the support for variables. More explanation in issue #9.

josephdadams commented 2 years ago

You can just call self.parseVariables on every value, no need to check if it contains $( first. And it would be better to only parse on the specific actions that you want to parse, rather than assuming every command sent should be parsed.

gerbenvandekraats commented 2 years ago

@josephdadams Those are some valid points, Thanks. I just edited it in a new commit.