search

bitfocus / companion-module-malighting-grandma2

grandMA2 support for companion
MIT License
12 stars 8 forks source link

Encoder Button not working #8

Closed Jpax411 closed 1 year ago

Jpax411 commented 2 years ago

When using the encoder buttons it adds " ", to the encoder value.

companion prob

who2us commented 2 years ago

please note the case sensitive true and false statements at the end of the Lua image a capital F and T should be used instead.

also the -1 is a half step to move a 0.1 step in Grandma please use -2 or 2 I tested the -20 to move the integer a negative 1.0 step

I have personally tested this, and works on version 3.9.60.45

who2us commented 1 year ago

@josephdadams could you please update the module with the required fix please? much appreciated.

vremm commented 1 year ago

I have tested and confirmed that a capital F or T gets the command to work.

In reference to the step move, is it possible to add in a custom step integer field?

KSchloe commented 1 year ago

Hey man!

did you fix this problem? Would be a really nice addition with the new Streamdeck+

Yours Kris

who2us commented 1 year ago

Hey @KSchloe yes i actually tested many variations on this, and this is the solution. just a capital letter :(

josephdadams commented 1 year ago

@who2us can you submit a pull request to fix it?

KSchloe commented 1 year ago

Hey @KSchloe yes i actually tested many variations on this, and this is the solution. just a capital letter :(

Can you please push a new revision? In Companion it's still the old one and If this works, it's a game changer in combination with the new streamdeck+.

istnv commented 1 year ago

This will be fixed in v3.0. There will also be a new press/release option for the encoders. The StreamDeck + knobs work this way.