bitfocus / companion-module-notion-timestamp

MIT License
0 stars 3 forks source link

update: to v3 compat module and parse variables for actions #3

Closed digitaldrummerj closed 1 year ago

digitaldrummerj commented 1 year ago

Changes:

2

josephdadams commented 1 year ago

@digitaldrummerj Overall this is great! Couple of things:

  1. consider adding yourself to manifest.json as a maintainer
  2. convert all var usage to let since it doesn't look like they need to be scoped globally at any point.
josephdadams commented 1 year ago

Also does this close out issue #2?

digitaldrummerj commented 1 year ago

Also does this close out issue #2?

It does not fully close it out since it was a list of several enhancements they would like to see and only a portion are included in this PR.

It felt like rearranging the column order and sorting column was a change that needed discussed before implementation. Same with the feedbacks since there was not any feedbacks today.

The two that were implemented and didn't feel like they would break anything existing were supporting variables in the action options and changing the timestamp to include the 00: hour when under an hour so you could sort on the timestamp column if you went over an hour.

digitaldrummerj commented 1 year ago

@josephdadams I added myself to the list of maintainers and changed the var to let.