bitfocus / companion-module-obs-studio

OBS Studio Module for Companion
MIT License
42 stars 28 forks source link

Sources not showing in Companion when OBS Group name has a space... #185

Closed UWSCIA closed 1 year ago

UWSCIA commented 1 year ago

Describe the bug While auditing triggers and buttons with the "beta" companion version as I needed the variable phrasing and newer websocket... I noticed not all Text sources were listed... I changed the name to remove spaces as this is normally the issue, but previous version didn't have this issue... didn't work... Then realized all the missing Text sources were in a Group, Changed the Group name to remove spaces... all Text Sources Showed up even the ones with spaces...

To Reproduce Steps to reproduce the behavior:

  1. Rename Group name with Text Sources in it to have a space
  2. Relaunch Companion... all Text Sources within Companion from that group gone.
  3. Rename Group name to have no spaces.. all Text Sources within Companion from that group return even if the text source has a space in the name...

Version Information:

bryce-seifert commented 1 year ago

I was able to recreate this and find the issue. It seems like some text sources weren't being properly pushed to the choices on startup (even though they were being recognized, as they appeared as a variable). I should have a fix for this in the next release