[BUG] obs - effect filters not listed in feedback for sources

[Marlow925]

Is this a bug in companion itself or a module?

• [X] I believe this to be a bug in companion

Is there an existing issue for this?

• [X] I have searched the existing issues

Describe the bug

Version 2.4.1+4898-v2-4.1-9646192a Platform: Windows 10

In the OBS module for Companion, "obs: Set Source Filter Visibility" lists both the "Audio/Video Filters" and the "Effect Filters".

I did have to restart Companion for it to list the filter, after I added it to OBS.

In the feedback section, "obs: Filter Enabled" does only list the "Audio/Video Filters" and not the "Effect Filters".

Steps To Reproduce

Go to buttons, create a new button, go to "Press actions", add "obs: Set Source Filter Visibility, select a Source, drop down the "Filter" list. Then go to "Feedback", add "obs: Filter Enabled", select that same Source, drop down the "Filter" list and compare. Effect Filters will not be included in the "obs: Filter Enabled" feedback.

Expected Behavior

Both "obs: Set Source Filter Visibility" and "obs: Filter Enabled" should list the same filters.

Environment (please complete the following information)

- OS: Windows 10
- Browser: Google Chrome 109.0.5414.120 (Official Build) (64-bit)
- Companion Version: 2.4.1+4898-v2-4.1-9646192a

Additional context

No response

[bryce-seifert]

I am able to recreate this. I will take a look!

[bryce-seifert]

This should be fixed with the recent rewrite of the module for Companion v3 https://github.com/bitfocus/companion-module-obs-studio/commit/8418babae579a75a6009c58a765246f666cad9d0