bitfocus / companion-module-obs-studio

OBS Studio Module for Companion
MIT License
44 stars 28 forks source link

"Source Visible in Program" feedback seems to have no effect #238

Closed phill-85 closed 1 year ago

phill-85 commented 1 year ago

Describe the bug "Source Visible in Program" feedback seems to have no effect.

image

image

Version Information:

phill-85 commented 1 year ago

The experimental version does not appear to work either.

bryce-seifert commented 1 year ago

I have not been able to recreate this.

Would you mind attaching your OBS scene collection file so I can test with that?

phill-85 commented 1 year ago

I double checked and still have the issue...

Page.companionconfig.txt Scene Collection.txt

bryce-seifert commented 1 year ago

@phill-85 Finally getting around to testing with your project, and I'm still having issues replicating.

Can you try the latest version of OBS and Companion to make sure?

Here's my test environment with the setup, and it is working for me:

Screenshot 2023-09-02 at 8 18 25 PM
phill-85 commented 1 year ago

I found if i turn 'duplicate sources' off in obs then "obs: Source Visible in Program" appears to start working as expected, turn it back on and it appears to break again.

image

bryce-seifert commented 1 year ago

Thanks for the additional information, I am able to replicate the issue after toggling Duplicate Sources.

However, I don't think there is a fix that can be implemented in the module, I think it will have to come from OBS or obs-websocket.

When I switch Duplicated Sources to "on" I get this event from obs-websocket { inputName: 'GREEN', videoActive: false } and likewise when I switch it "off", I get { inputName: 'GREEN', videoActive: true }

So there's nothing that can currently be done within the module to detect this behavior and account for it. My first recommendation would be to find workarounds to using Duplicated Source, or if that is not possible raise an issue with obs-websocket, as we would need that data to be correct in order for the feedback to work properly.