search

bitfocus / companion-module-openlp-http

MIT License
4 stars 4 forks source link

Add Next/Previous Service Items and tidy up a bit #1

Closed mrlenny closed 4 years ago

krocheck commented 4 years ago

@mrlenny I can't properly evaluate this because the entire file was change from tab indentations to spaces. You will need to correct this so I can see a proper diff.

mrlenny commented 4 years ago

is there a way to ignore whitespace in diffing? My editor just re-aligns everything when I save the document.

mrlenny commented 4 years ago

Yes, there is!

wschanges

krocheck commented 4 years ago

That's fine for me to review your code changes, but I'm not going to actually merge this until the file is changed back to tabs.

krocheck commented 4 years ago

Have you tested the these changes work against the product? Code changes seems fine otherwise.

mrlenny commented 4 years ago

I haven't tested the changes, how do I generate a build?

krocheck commented 4 years ago

Mac or Win? Do you have the companion git cloned to your computer?

mrlenny commented 4 years ago

Win, and no clone, I just edited in notepad++ and pasted the file into the browser.

On Mon, Jun 29, 2020 at 3:02 PM Keith Rocheck notifications@github.com wrote:

Mac or Win? Do you have the companion git cloned to your computer?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-openlp-http/pull/1#issuecomment-651329109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF57K4QNHBV7F4HCOKEAQDRZDXL7ANCNFSM4OLQ422Q .

-- Matthew Courville

krocheck commented 4 years ago

Gotcha. Do you plan on contributing more or is this a one-off? If its just a one-off I can validate the code then get a beta build off for you to test.

mrlenny commented 4 years ago

most likely a one-off. I have a severe dislike for javascript, but I wanted to get this functionality added quickly.

krocheck commented 4 years ago

Ok ... syntax-wise this seems fine. I'm going to merge and fire a build, which will take about a half hour. Please download and test that build from the Companion website. Once done, I'll need you to report back here if the changes are working as intended. Thanks!

mrlenny commented 4 years ago

Works great! ship it!