search

bitfocus / companion-module-openlp-http

MIT License
4 stars 4 forks source link

support for openlp 3.0 #11

Closed jendamozna closed 2 years ago

jendamozna commented 2 years ago

new version with support of openlp 3.0, version can be selected in config, feedbacks structure updated

josephdadams commented 2 years ago

I think you might need an upgrade script for this so that the self.config.version property is not undefined for older instances/users of this module. If I recall, it is not enough to set a default value for the property in the config fields, because that won't actually get set until the user goes to edit the module config and clicks update.

Also I noticed that you throw a warning for an action not supported in version 2 - but since you know the version, what about just not even providing that action as a choosable option if that's the version they selected?

jendamozna commented 2 years ago

upgrade script added, v3 only function hidden when running v2