search

bitfocus / companion-module-openlp-http

MIT License
4 stars 4 forks source link

Crashes companion when using version 2.9.2 of OpenLP #8

Closed chippieuk closed 2 years ago

chippieuk commented 3 years ago

I thought I'd test out the latest beta of OpenLP (v2.9.2) and found the unexpected result of it crashing companion. The web interface shows the 'Houston we have a problem' message as soon as OpenLP is opened. Closing OpenLP then re-starting comapnion resolves this, as does disabling the OpenLP plugin on companion.

jendamozna commented 3 years ago

It doesnt seem to be related to companion-module-openlp-http. OpenLP 2.9.2 is still in beta. GET /api/poll currently returns "null" instead of json response, which causes companion crash.

Rereported to openlp: https://gitlab.com/openlp/openlp/-/issues/890

response should be verified here: https://github.com/bitfocus/companion-module-openlp-http/blob/master/index.js#L352

trb143 commented 3 years ago

The API will be changing and moving to WebSockets. We will be removing the POLL API in future releases.

jendamozna commented 3 years ago

Fixed in 2.9.3