Variable parsing for SetIncDec actions

bitfocus / companion-module-panasonic-cameras

MIT License

7 stars 2 forks source link

Variable parsing for SetIncDec actions #19

Closed phillipivan closed 3 weeks ago

phillipivan commented 1 month ago

Define new Action Options for SetIncDec actions #18
Parse Variables in actions
Upgrade script to ensure new options arent undefined
Define new options in presets

To do:

[ ] Test

Fixes #18 #3

phillipivan commented 1 month ago

@JuddiP has done some testing and so far things seem ok.

JuddiP commented 1 month ago

Tested custom variables in the following actions with Panasonic AK-UB300, HE130 & UE50:

Iris: Values map incorrectly (eg. custom variable or raw number set to 100 results in step change of 90, custom variable or raw number set to 50 results in step change of 30).
Pedestal: Success
Pedestal Red: Success
Pedestal Blue: Success
Gain Red: Success
Gain Blue: Success

@premultiply everything but the Iris action is working as expected. Possibly something further upstream in the code?

The upgrade script is also working as expected.

premultiply commented 1 month ago

Pushed some untested simplifications.

JuddiP commented 3 weeks ago

Please reach out when you think this is all in a good place to perform more testing. I will pull it into a local instance on site and test it against UB300, HE130 and UE50 camera models.

premultiply commented 3 weeks ago

I think it is ready for testing. Haven't tested it myself yet...

JuddiP commented 3 weeks ago

Hi @premultiply -- are you able to create a build for me to test? I'm not familiar with the process.

premultiply commented 3 weeks ago

@JuddiP Please see https://github.com/bitfocus/companion/wiki/How-to-use-a-module-that-is-not-included-in-Companion-build