search

bitfocus / companion-module-panasonic-ptz

MIT License
8 stars 17 forks source link

OTF Function and PT Speed #12

Closed JoRaeBim closed 3 years ago

JoRaeBim commented 4 years ago

Added OTF function and corrected the Failure that "Up" and "Down" doesn't work after setting PT Speed.

krocheck commented 4 years ago

@JoRaeBim there appears to have been a linting done on the file. Unfortunately the majority of those need to be reversed since they go against norms in the project. Where it did inline alignments (as in the actions), that is fine, but places where it removed 'errant' spaces around commas and plus signs need to be restored.

McHauge commented 4 years ago

I think most of what you have in here, should be in the module by now, after the update I just made. but without the need to reverse all the lining. gonna test it out next weekend and after that, it will get included into the core.

McHauge commented 3 years ago

I'll close this request, since this is now a part of the Module in the beta builds