search

bitfocus / companion-module-renewedvision-propresenter

Renewed Vision Pro Presenter
MIT License
31 stars 19 forks source link

[BUG] #161

Open N00bianGod opened 1 year ago

N00bianGod commented 1 year ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

As far as I can tell all ProPresenter7 variables that show Clocks / Timers live within BitFocus Companion buttons with the button text being filled with a variable such as: $(ProPresenter 7 (LiveStream):video_countdown_timer_hourless)

Steps To Reproduce

  1. Establish a good connection between ProPresenter 7 and Bitfocus Companion
  2. Create a new button
  3. Enter the following into the button text: $(ProPresenter 7 (LiveStream):video_countdown_timer_hourless)
  4. Click on any video within ProPresenter 7
  5. No timer will display

Expected Behavior

Once the ProPresenter has a good Green / OK connection with BitFocus Companion one should be able to create a button with a countdown or timer variable that will show the respective clock time for the action taken within the buttons page of BitFocus Companion. Example: I create a Countdown Timer button > I click on a Video > I should see that button turn into a countdown of minutes / seconds to run till it reaches 00:00 at the end of the video when it finishes playing.

Environment (please complete the following information)

- OS: MacOS 12.6 Monterey
- Browser: Chrome Version 113.0.5672.92 (Official Build) (x86_64)
- Companion Version: 2.4.2 (2.4.2+4911-v2-4.2-fcb5a863)

Additional context

This was working prior to maybe a few months ago, perhaps prior to Christmas 2022? It has been a while. Sorry for the delay.

Julusian commented 1 year ago

Things frequently break in this module when updating propresenter. I remember seeing on facebook about something which broke with the latest version (7.13?) and downgrading to the previous version of propresenter resolved it.

N00bianGod commented 1 year ago

Interesting. I was on 7.13 of ProPresenter. I’ll drop down to 7.12 and see if that works again.

greyshirtguy commented 1 year ago

They changed the format/syntax of the JSON response when asking for timers values.... We would need to consider updating it to work with older format from odler version and newer format from newer versions.