bitfocus / companion-module-renewedvision-propresenter

Renewed Vision Pro Presenter
MIT License
31 stars 19 forks source link

Specific Slide does not send any information #165

Open dmlodzik opened 1 year ago

dmlodzik commented 1 year ago

When using the specific slide function, nothing happens. Clear-all, changing stage display layouts all work correctly, but when trying to trigger a specific slide, nothing happens. When looking at the log, after sending the trigger, nothing gets added to the log. Its as if literally nothing happens.

Working on Companion 3.0.0 Propresenter 7.13.1 Mac OS 13.1.1

Attached is a screenshot of the log - sent clear all then specific slide three times in a row, then change stage display layout, then specific slide again. None of the specific slide triggers show up. Screenshot 2023-06-14 at 7 47 16 PM

tonybeatle commented 1 year ago

I am having the same bug on my set up. all other commands work, but anything related to a specific slide do not work.

Instance/Wrapper/ProPresenter: Error executing action: Cannot read properties of undefined (reading 'emit')

Julusian commented 1 year ago

Hopefully this is working in beta 5973

natereprogle commented 1 year ago

If you look at your full logs at http://localhost:8000/log (Or whatever port you use), I believe you will see an error that states "Instance/Wrapper/propresenter: Error executing action: Cannot read properties of undefined (reading 'dynamicVariables')". This is what I'm experiencing, and the symptoms are the same as what you've described. Unfortunately, I have no idea how to trace that down because line numbers or things of that nature are not placed in debug logs to diagnose. dynamicVariables is used quite often in the module. However, figured I'd report what I'm seeing anyway

image

Julusian commented 1 year ago

@natereprogle using 3.0.0-rc2 or a more recent beta?

natereprogle commented 1 year ago

@natereprogle using 3.0.0-rc2 or a more recent beta?

I’m using the latest Beta, or whatever the latest Beta was as of yesterday morning haha

dmlodzik commented 1 year ago

I've tried using both the latest beta, and 3.0.0-rc2 today, and neither are working. Attached is a screenshot of what happens when I press the button. In the beta its telling me its sending a JSON - but nothing happens in Propresenter. Clear all and change stage display works as normal - only issue is still with triggering specific slides. Screenshot 2023-07-12 at 7 08 32 PM

dmlodzik commented 1 year ago

Update. If I add another action to the same button that is specific slide with label - that will work. Once I've used that once - then my other Specific Slide triggers work fine, even without a specific slide with label title on it.

greyshirtguy commented 1 year ago

Interesting, I'd guess that an internal variable is not being automatically updated and that the "specifc slide" action depends on that variable. And the "Specific Slide with Label" action manually refreshes that internal variable. Between now and a fix, you might consider just using Specific slide with label - it's a bit more flexible!

greyshirtguy commented 1 year ago

Fixed in code - I'll update when a new beta build has the fix.

HBCMissionControl commented 11 months ago

Any update when a beta might have a fix? I'm having the same problem, but it seems like every time I quit Pro Presenter I lose the button functionality again. If I do a fresh install of companion, the button will work as long as Pro Presenter is open. When I quit and relaunch the button stops working again. Tried 3.0.1 (3.0.1+6068-stable-a05a9c89) and 3.1.0+6218 beta with the same results.

SamSMithy15 commented 5 months ago

Im still having this issue to this day even with the stable 3.2.2 and beta.