bitfocus / companion-module-renewedvision-propresenter

Renewed Vision Pro Presenter
MIT License
31 stars 19 forks source link

Clock Shave Time Functionality #166

Open DanielHardaway opened 1 year ago

DanielHardaway commented 1 year ago

Describe the bug/issue In the PP7 module, we can successfully define a clock value using the "Update Clock" action followed by "Reset Clock". This works as expected in the v3.0.0 release. In past releases, we could add a + or - prefix to add or subtract time to/from the current time of the clock. This seems to be broken in v3.0.0 and also the 5992 beta.

To Reproduce Steps to reproduce the behavior: Make a button using module for PP7 machine. Add update clock action and configure as usual. Add + or - prefix and an amount of time. For example -00:00:30 Add reset clock action with a delay of 100ms. Add start clock action with a delay of 200ms. Run the timer at a value of 00:45:00 or any time either manually or via another button. Press the time modifier button. Time does not modify. Clock resets to the original value of 00:45:00 and counts from there again.

Expected behavior In pre-v3.0.0 versions of companion, we used this time modifying method extensively for years with great success. Was always very reliable and consistent. Time would smoothly update on a currently running clock.

Screenshots

Screen Shot 2023-06-25 at 1 10 41 PM

Versions/Environment:

greyshirtguy commented 1 year ago

This should be fixed in recent code update. I'll update if/when a new beta build includes it.

alexanderhingston commented 9 months ago

@greyshirtguy

Hello, Would be excited to get this working! Are there any updates?

cheers, Alex