Constant crashing of module

[justingiffard]

Describe the bug/issue The module continuously crashes, and only sometimes does actions and feedback work Have tried deleting and re-adding module

To Reproduce Steps to reproduce the behavior:

1. Add module
2. setup connection
3. save

Expected behavior A stable connection that controls PP7

Screenshots Please add screenshots (or full text descriptions) showing:

• ProPresenter module config.

• module in crashed state https://www.dropbox.com/scl/fi/l223yvyiajvqgo3ub9gjb/SmartSelect_20230924_081323_Chrome.gif?rlkey=7gffxq4p1iv2osopcs6p7pb2s&dl=0 // github not letting me upload gif so heres a link to it on dropbox

• button using module (weirdly one of variables gets a value but doesnt update

Versions/Environment (please complete the following information):

• ProPresenter Version [e.g. 7.9.2] 7.14.1 (118358275)

• OS of ProPresenter Machine [e.g. MacOS 11.6/Windows 10] MacOS 13.4.1

• Companion Version [e.g. 2.3 ] 3.1.0+6088-beta-9c309603

• OS of Companion machine [[e.g. MacOS 11.6/Windows 10] Same machine: MacOS 13.4.1

• Debug log output when issue occurs (Turn on debug log) This is repeated indefinitely in the logs Log:

  
  debug: Looks changed. Updated internal list 
  error: /Applications/Companion.app/Contents/Resources/bundled-modules/renewedvision-propresenter/main.js:2
  (()=>{var e={2644:function(e,t,n){const{Regex:s,InstanceStatus:i}=n(8049),r={enableFollowerControl:"enableFollowerControl",next:"next",last:"last",slideNumber:"slideNumber",slideLabel:"slideLabel",groupSlide:"groupSlide",clearall:"clearall",clearslide:"clearslide",clearprops:"clearprops",clearaudio:"clearaudio",clearbackground:"clearbackground",cleartelestrator:"cleartelestrator",cleartologo:"cleartologo",clearAnnouncements:"clearAnnouncements",clearMessages:"clearMessages",stageDisplayLayout:"stageDisplayLayout",pro7StageDisplayLayout:"pro7StageDisplayLayout",pro7SetLook:"pro7SetLook",pro7TriggerMacro:"pro7TriggerMacro",stageDisplayMessage:"stageDisplayMessage",stageDisplayHideMessage:"stageDisplayHideMessage",clockStart:"clockStart",clockStop:"clockStop",clockReset:"clockReset",clockUpdate:"clockUpdate",messageHide:"messageHide",messageSend:"messageSend",audioStartCue:"audioStartCue",audioPlayPause:"audioPlayPause",timelinePlayPause:"timelinePlayPause",timelineRewind:"timelineRewind",customAction:"customAction",nwSpecificSlide:"nwSpecificSlide",nwPropTrigger:"nwPropTrigger",nwPropClear:"nwPropClear",nwMessageClear:"nwMessageClear",nwTriggerMedia:"nwTriggerMedia",nwTriggerAudio:"nwTriggerAudio",nwVideoInput:"nwVideoInput",newRandomNumber:"newRandomNumber",nwCustom:"nwCustom"},o=async e=>{e.data.connection={rejectUnauthorized:!1},this.instance.log("debug",`Sending: http://${this.config.host}:${this.config.port}${e.endpointPath} ${JSON.stringify(e.data)}`);const t=await fetch(`http://${this.config.host}:${this.config.port}${e.endpointPath}`,{body:JSON.stringify(e.data)});if(t.ok){const e=await t.json();this.instance.log("debug",JSON.stringify(e))}},a=async e=>{if(this.instance.currentStatus!==i.UnknownError)try{const t=JSON.stringify(e);this.instance.log("debug","Sending JSON: "+t),this.instance.socket.send(t)}catch(e){this.instance.log("debug","NETWORK "+e),this.instance.updateStatus(i.UnknownError,e.message)}else this.instance.log("debug","Socket not connected :("),this.instance.updateStatus(i.ConnectionFailure,"not connected")};e.exports={GetActions:e=>(this.instance=e,{[r.next]:{name:"Next Slide",options:[],callback:async()=>{await a({action:"presentationTriggerNext",presentationDestination:"0"})}},[r.last]:{name:"Previous Slide",options:[],callback:async()=>{await a({action:"presentationTriggerPrevious",presentationDestination:"0"})}},[r.slideNumber]:{name:"Specific Slide",options:[{type:"textinput",useVariables:!0,label:"Slide Number",id:"slide",default:"1",tooltip:"(Supports variable)",regex:s.SIGNED_NUMBER},{type:"textinput",useVariables:!0,label:"Presentation Path",id:"path",default:"",tooltip:"See the README for more information (Supports variable)",regex:"/^$|^\\d+$|^\\d+(\\.\\d+)*:\\d+$/"}],callback:async(e,t)=>{let n=this.instance.currentState.internal.slideIndex;const s=await t.parseVariablesInString(String(e.options.slide).trim());"-"===e.options.slide[0]||"+"===e.options.slide[0]?(n+=parseInt(e.options.slide.substring(1),10)*("+"===e.options.slide[0]?1:-1),n=Math.max(0,n)):n=parseInt(s)-1,n<0&&(n=this.instance.currentState.internal.slideIndex);const i=await t.parseVariablesInString(String(e.options.path).trim());let r=this.instance.currentState.internal.presentationPath;void 0!==e.options.path&&null!==String(e.options.path).match(/^\d+$/)?r=r.split(":")[0]+":"+e.options.path:""!==e.options.path&&(r=i);const o={action:"presentationTriggerIndex",slideIndex:String(n),presentationPath:r};await a(o)}},[r.slideLabel]:{name:"Specific Slide With Label",options:[{type:"textinput",useVariables:!0,label:"Playlist Name",tooltip:"Find the first playlist with that matches this playlist name (Supports variable)",id:"playlistName"},{type:"textinput",useVariables:!0,label:"Presentation Name",tooltip:"Find the first presentation (in above playlist) that matches this presentation name (Supports variable or text with wildcard char *)",id:"presentationName"},{type:"textinput",useVariables:!0,label:"Slide With Label",tooltip:"Find the first slide (in above presentation) with matching *Slide Label* and trigger that slide (Supports variable)",id:"slideLabel"}],callback:async(e,t)=>{const n={playlistName:await t.parseVariablesInString(String(e.options.playlistName).trim()),presentationName:await t.parseVariablesInString(String(e.options.presentationName).trim()),slideLabel:await t.parseVariablesInString(String(e.options.slideLabel).trim())};this.instance.currentState.internal.awaitingSlideByLabelRequest=n,await a({action:"playlistRequestAll"})}},[r.groupSlide]:{name:"Specific Slide In A Group",options:[{type:"textinput",useVariables:!0,label:"Group(s) Name",tooltip:"Specify the Name of the Group with the slide you want to trigger (Supports variable or multiple group names separated by |)",id:"groupName"},{type:"textinput",useVariables:!0,label:"Slide Number (Within Group)",default:"1",tooltip:"Which slide in the group? (Supports variable)",id:"slideNumber",regex:s.NUMBER},{type:"textinput",useVariables:!0,label:"Presentation Path (Leave Blank for Current)",id:"presentationPath",default:"",tooltip:"Leave this blank to target the current presentation (Supports variable)",regex:"/^$|^\\d+$|^\\d+(\\.\\d+)*:\\d+$/"}],callback:async(e,t)=>{const n=await t.parseVariablesInString(String(e.options.groupName).trim()),s=await t.parseVariablesInString(String(e.options.slideNumber).trim());let i=await t.parseVariablesInString(String(e.options.presentationPath).trim());if(0==i.length&&(i=this.currentState.dynamicVariables.current_presentation_path),void 0!==i&&"undefined"!==i&&i.length>0){const e={groupName:n,slideNumber:s,presentationPath:i};this.instance.currentState.internal.awaitingGroupSlideRequest=e;const t={action:"presentationRequest",presentationPath:i,presentationSlideQuality:0};await a(t)}}},[r.clearall]:{name:"Clear All",options:[],callback:async()=>{await a({action:"clearAll"})}},[r.clearslide]:{name:"Clear Slide",options:[],callback:async()=>{await a({action:"clearText"})}},[r.clearprops]:{name:"Clear Props",options:[],callback:async()=>{await a({action:"clearProps"})}},[r.clearaudio]:{name:"Clear Audio",options:[],callback:async()=>{await a({action:"clearAudio"})}},[r.clearbackground]:{name:"Clear Background",options:[],callback:async()=>{await a({action:"clearVideo"})}},[r.cleartelestrator]:{name:"Clear Telestrator",options:[],callback:async()=>{await a({action:"clearTelestrator"})}},[r.cleartologo]:{name:"Clear to Logo",options:[],callback:async()=>{await a({action:"clearToLogo"})}},[r.clearAnnouncements]:{name:"Clear Announcements",options:[],callback:async()=>{await a({action:"clearAnnouncements"})}},[r.clearMessages]:{name:"Clear Messages",options:[],callback:async()=>{await a({action:"clearMessages"})}},[r.stageDisplayLayout]:{name:"Pro6 Stage Display Layout",options:[{type:"textinput",label:"Pro6 Stage Display Index",id:"index",default:"0",regex:s.NUMBER}],callback:async e=>{const t={action:"stageDisplaySetIndex",stageDisplayIndex:String(e.options.index)};await a(t)}},[r.pro7StageDisplayLayout]:{name:"Pro7 Stage Display Layout",options:[{type:"dropdown",label:"Pro7 Stage Display Screen",id:"pro7StageScreenUUID",tooltip:"Choose which stage display screen you want to update layout",default:"",choices:this.instance.currentState.internal.pro7StageScreens},{type:"dropdown",label:"Pro7 Stage Display Layout",id:"pro7StageLayoutUUID",tooltip:"Choose the new stage display layout to apply",default:"",choices:this.instance.currentState.internal.pro7StageLayouts}],callback:async e=>{const t={action:"stageDisplayChangeLayout",stageScreenUUID:e.options.pro7StageScreenUUID?e.options.pro7StageScreenUUID:this.instance.currentState.internal.pro7StageScreens[0].id,stageLayoutUUID:e.options.pro7StageLayoutUUID?e.options.pro7StageLayoutUUID:this.instance.currentState.internal.pro7StageLayouts[0].id};await a(t)}},[r.pro7SetLook]:{name:"Pro7 Set Look",options:[{type:"dropdown",label:"Look",id:"pro7LookUUID",tooltip:"Choose which Look to make live",default:"",choices:this.instance.currentState.internal.pro7Looks}],callback:async e=>{const t={action:"looksTrigger",
  error: 
  Node.js v18.16.0```

[osuna1]

Had this issue as well and searched for a solution for quite a bit.

The solution I found was to:

• First: add a new look to Pro7 that duplicates your normal settings for screens/media output. (if you look at the connection log for your Pro7 module the connection crashes seem to be tied to companion trying to set a look that doesn't exist.)
• Second: In your Pro7 configuration for companion, change the "Type of Presentation info Requests" from "Automatic" to "Manual"
• Lastly: Make sure to save your configuration and restart the companion instance.

I had to manually make these changes on all of my companion instances but, after that haven't really had issues with it. I was holding off updating to v3.1.2 because of this problem but after finding this work around updated all of my instances for the new feature sets.

Hope this helps.