bitfocus / companion-module-renewedvision-propresenter

Renewed Vision Pro Presenter
MIT License
31 stars 19 forks source link

unstable connection with ProPresenter 7 [BUG] #174

Open evan-fbcs opened 11 months ago

evan-fbcs commented 11 months ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

We use Streamdeck and Companion to trigger macros and other actions in ProPresenter 7. Lately, Companion's connection with ProPresenter has been shaky at best. Once everything is opened up, the connection will drop and reconnect about once every second. It seems like it's blinking. Then after a few minutes of that happening, the connection will drop altogether.

We also have an instance in Companion for controlling an Atem Mini, and that connection never wavers.

Currently, we are working with ProPresenter 7.13.2. We were having major issues with 7.14.1, and based on the release notes from 7.14.2, none of the issues we were experiencing were resolved.

Both the iMac and the Atem Mini are connected to our network via ethernet.

What are some steps I could take to ensure a secure connection between Companion and ProPresenter?

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: macOS Ventura 13.5.2
- Browser: Google Chrome
- Companion Version: v3.0.1

Additional context

No response

srmorris2 commented 11 months ago

I can add that I am seeing this issue as well. Looking at the log, maybe it has something to do with this connection to a child? We are not using the "master control" work around, but it seems that it's trying anyway?

23.10.09 11:27:55 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX5:connection_timer\"]}"}
23.10.09 11:27:55 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX2:time_since_last_clock_update\"]}"}
23.10.09 11:27:55 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX2:connection_timer\"]}"}
23.10.09 11:27:55 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-VisionTV:connection_timer\"]}"}
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"internal:time_hms\",\"internal:time_s\",\"internal:time_unix\",\"internal:time_hms_12\"]}"}
23.10.09 11:27:56 Instance/ModuleHost: Registered module client "YK0R17VLC1PCnTx-7bVlX"
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: ProPresenter Disconnected
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: ProPresenter Disconnected
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Starting ConnectionTimer
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: ProPresenter Disconnected
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Starting ConnectionTimer
23.10.09 11:27:56 Instance/Controller: instance "Pro7-GFX1" configuration updated
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Opened websocket to ProPresenter remote control: 10.0.32.149:49572
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Opened websocket to ProPresenter stage display: 10.0.32.149:49572
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: ProPresenter Stage Display Connected
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Authenticated to ProPresenter (Version: 7)
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: ProPresenter Connected
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Slide Triggered: undefined.8 on layerid: 0
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Got Pro7 Stage Display Sets
23.10.09 11:27:56 Instance/Wrapper/Pro7-GFX1: Got Pro7 Macros List
23.10.09 11:27:57 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"internal:time_hms\",\"internal:time_s\",\"internal:time_unix\",\"internal:time_hms_12\"]}"}
23.10.09 11:27:57 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX5:connection_timer\"]}"}
23.10.09 11:27:57 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX2:time_since_last_clock_update\"]}"}
23.10.09 11:27:57 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-GFX2:connection_timer\"]}"}
23.10.09 11:27:57 Instance/Wrapper/Pro7-GFX1: Child is not running, unable to send message: {"direction":"call","name":"variablesChanged","payload":"{\"variablesIds\":[\"Pro7-VisionTV:connection_timer\"]}"}
23.10.09 11:27:57 Instance/ModuleHost: Registered module client "YK0R17VLC1PCnTx-7bVlX"
srmorris2 commented 11 months ago

Adding some more information, I have replicated this issue on two different machines. Both running 7.14.1, one on Mac OS 12.7, one on 13.6.

Also, the disconnect only seems to happen when there is an active slide in a presentation. Playing a video, or clearing all stops the repeating disconnect.

isaacclausen commented 11 months ago

I am also having this issue as well. Companion 3.1.0, macOS 13.3.1. When slide is active, blinking "initializing" status about every second, then "ERROR WebSocket was closed before the connection was established".

module-log-10_9_2023-4_41_22 PM.csv

ckmieick commented 11 months ago

Same issue here. It has been happening for a while but I am just now getting around to trying to fix it. As stated before, the connection drops every second or two when there is an active slide. Once I clear the slide the connection becomes stable again. I am on a Mac Running Ventura (though it was also doing it when I was running Catalina earlier this week). I am on Propresenter 7.14.1 (I was on 7.13.x earlier this week as well with the same issue). I just updated companion to 3.1.1 and still have the same issue. Hopefully we can get this bug resolved as I love my companion/propresenter integration.

nprail commented 10 months ago

Also experiencing the same issue with PP 7.14.1, Companion 3.1.1, and macOS Ventura (13.5.2). Companion and ProPresenter are running on separate Macs. The connection also seems to be stable when there are no active slides as others have noticed.

micahptech commented 10 months ago

I've been having the same issues as everyone in this thread. I have multiple Mac machines running ProPresenter7.14.1 and are all having this issue, I have one iMac still running 7.10.4 and it's been working perfectly. Does anyone know of a fix?

ckmieick commented 10 months ago

Looking at issue #167 thread they mentioned in the module settings to turn "Type of presentation info requests" from automatic to manual. Not sure what that does and what else it impacts but my connection is now stable with active slides after making that change.

The-Arsonist commented 7 months ago

Looking at issue #167 thread they mentioned in the module settings to turn "Type of presentation info requests" from automatic to manual. Not sure what that does and what else it impacts but my connection is now stable with active slides after making that change.

This fixed my issues. I use a stream deck to control propresenter and it would often not connect, but changing this setting to manual seems to have fixed the issue

DrEVILish commented 5 months ago

"Type of presentation info requests" from automatic to manual.

This has also fixed my issues as well.