search

bitfocus / companion-module-renewedvision-propresenter

Renewed Vision Pro Presenter
MIT License
31 stars 19 forks source link

Network link features don't work #180

Open jamseong opened 7 months ago

jamseong commented 7 months ago

Describe the bug/issue Network Link features do not work as intended.

To Reproduce Steps to reproduce the behavior:

  1. Enable Network Link image
  2. Add a button with a Network Link action e.g. Trigger Video Input image
  3. Trigger button
  4. Logs shows this error Instance/Wrapper/propresenter: Error executing action: Cannot read properties of undefined (reading 'host')

Expected behavior Trigger should fire as intended.

Versions/Environment (please complete the following information):

*Any Other Context Using a Generic HTTP Get Command works as intended: http://192.168.68.127:1025/v1/video_inputs/0/trigger

mrderkis commented 7 months ago

Same issue. Has been this way for quite a while. I am hoping it eventually will be fixed. It seems to work on the native stream deck app but I much prefer to use companion and not the companion plugin with the SD software.

dali01 commented 5 months ago

This is absolutely causing issues for our church volunteers. Seeing @greyshirtguy is the main contributor, I'll humbly ask for help here.

astrodad commented 2 months ago

New user here and echo the sentiments. In my instance, nothing appears in the log at all. Link is enabled. In the Companion log, it shows 

24.06.30 11:49:54 Instance/Wrapper/propresenter: Error executing action: Cannot read properties of undefined (reading 'host')
vowchr commented 4 weeks ago

Any updates on this issue? Seems to me that an important part of PP cannot be handled with companion since January?

greyshirtguy commented 4 weeks ago

Hi everyone... It's been a while since I've looked at this!! Sorry. I am working on a new replacement module that works with the new API - The current/old module uses undocumented/reverse engineered protocols - that RV can (and do) change without worrying about impact to clients that use it....

I expect new module to be ready to beta test in next few months...

in the mean time.... as per the OP has mentioned..... you can use the API directly - it's MUCH better! I CAN show you how to use API directly to achieve any action you want NOW...

Give me a couple of weeks and I'll make and share a Youtube tutorial (on using API directly with generic HTTP module) that you can follow along and make actions to achieve anything (that the new API can do) NOW.

paulstec commented 4 weeks ago

@greyshirtguy , thank you for you response about a tutorial.

Will it include using the APIs with the chunked option equaling true? If so can you provide a hint how that would work?

As suggested, I'm using the Generic HTTP module for the few ProPresenter API calls we use. Then adding triggers to poll for changes.

Wondering if using chunked=true would provide updates when things change, so polling with triggers would not be necessary. (Please let me know if this is a wrong assumption.)

I haven't been able to get chunked=true to work.

Thanks.

greyshirtguy commented 4 weeks ago

As far as I know , there is no way of parsing chunked responses using Companion Actions/Expressions/Triggers/Modules/Etc! For now, just use polling - it feels a bit yucky - bit it;s fine..

vowchr commented 4 weeks ago

Hi @greyshirtguy Thank you very much for the offer with the API tutorial. That would help me a lot! I'm also glad to hear that a new connection for Propresenter is being worked on - with all the open issues here I was afraid that this would no longer be maintained.