bitfocus / companion-module-requests

Repository for tracking module requests
100 stars 11 forks source link

Request for support of Roland VR-50HD MKII video switcher #107

Closed mko1989 closed 4 years ago

mko1989 commented 4 years ago

Basically the same control standard as V60-HD with a couple different commands.

Here is a link to the reference manual with all the commands: https://proav.roland.com/global/support/by_product/vr-50hd_mk_ii/owners_manuals/df616773-c6e6-42e7-8f86-c89f61885d55/

McHauge commented 4 years ago

I'll take a look at it, but I guess some of the V-60HD modules also works with this unit but will make a new module, will probably have a test build ready next week.

josephdadams commented 4 years ago

@McHauge i’m happy to take a look, since I’ve created all the other Roland modules.

McHauge commented 4 years ago

If you want to you can then just swap the assigned to, back to you

josephdadams commented 4 years ago

@mko1989 just waiting on the repo to be set up. The module is ready.

josephdadams commented 4 years ago

@mko1989 code is uploaded. https://github.com/bitfocus/companion-module-roland-vr50hd-mk2 Do you have a development environment set up where you could test this? Or do you need a binary built?

josephdadams commented 4 years ago

@mko1989 go download the latest bleeding edge build of 2.0 from http://builds.bitfocus.io and test this out please. Report back any issues. Thanks!

josephdadams commented 4 years ago

@mko1989 how did testing go?

mko1989 commented 4 years ago

Sorry about that. I went ahead of time with that module request. My company is getting few units of that Roland but in a few weeks. As soon as we get them I will test it but it will take some time. Sorry for that.

sob., 2 lis 2019, 11:49 użytkownik Joseph Adams notifications@github.com napisał:

@mko1989 https://github.com/mko1989 how did testing go?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-requests/issues/107?email_source=notifications&email_token=AKTSGMNP6IPOTC4GVX2RD6TQRVLKTA5CNFSM4JE7XZD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC4ZCMA#issuecomment-549032240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKTSGMNH5Q2RU4OM5MN5SOTQRVLKTANCNFSM4JE7XZDQ .

josephdadams commented 4 years ago

@mko1989 let me know how testing goes. Thanks!

josephdadams commented 4 years ago

@mko1989 did you get your units yet?

mko1989 commented 4 years ago

Finally got them yesterday. Had a little time for testing but in that time everything seemed to work fine. The only thing i noticed was that in option "Select source video for video input" there is "Still" in the Input number drop down which doesn't work nor it should. There is another option "Select still image of the STILL button" which does that and works as expected. I will do more testing soon when I have the time but for now it seems very good. Thanks Guys

josephdadams commented 4 years ago

Thanks! I thought that was strange too, but it was listed in the official reference manual from Roland, so I put it in there. Now we know that was not correct. I’ll remove it and update the repository.

josephdadams commented 4 years ago

@mko1989 I've fixed this in the code. @JeffreyDavidsz will update the core and when the build server is working correctly again you can download an updated version of Companion from builds.bitfocus.io.

mko1989 commented 4 years ago

Had a little time with the vr-50 today and found another bug, in the select video for AUX bus there is a still source in the drop down which is not available in the actual unit. Please remove this option from the drop down. Thanks a lot for the module :)

josephdadams commented 4 years ago

@mko1989 fixed in the code. The manual lists it but actually lists them like this: 0 (INPUT 1) 1 (INPUT 2) 2 (INPUT 3) 3 (INPUT 4) 4 (STILL) 4 (PinP) 5 (PinP/KEY) 6 (PGM)

As you can see, id 4 is duplicated. I had simply incremented them in the code assuming the id numbers were typos, but now we can see that it's the entire STILL entry is the typo. :) Please test PinP, PinP/Key, and PGM.

@JeffreyDavidsz can you update this in the core and set off a build?

JeffreyDavidsz commented 4 years ago

check