bitfocus / companion-module-shure-wireless

MIT License
4 stars 9 forks source link

[BUG] Shure-Wireless not working for QLX-D in beta release; no response from author #13

Closed jsnyder886 closed 2 years ago

jsnyder886 commented 2 years ago

Describe the bug Since the 2.2.0 beta went into development, the shure-wireless module has not worked properly. Attempts have been made by several folks to reach out to the author of the monitor for assistance, however it has been to no avail as no return communication has been received. Speaking only for myself, I am eternally grateful for the countless hours the team of dedicated developers pour into Companion, so this is in no way a criticism. That said, the previous version of the module did in fact work properly,

To Reproduce Choose the QLX-D receiver type in the instance setup. It will then show that it is connected to the receiver (after entering your correct IP address of course), but no data is sent or received to or from the device to companion. Literally nothing is available to use and the instance reports that is it "OK."

Expected behavior The instance should work, at all.

Additional context I know this module is designed for several types of shure wireless receivers, and it would appear that for the other receiver types the module is performing as expected as the complaints seems focused on the QLX-D receiver. Rather than rolling back the module to a previous state and potentially wiping out functionality that those other users may be reliant upon, I propose creating a new instance for the rollback, titled similarly, with perhaps "legacy" appended to the title. This would allow those for which the module is working properly to continue to work without disruption, and for those of us that have been waiting for a response, we could at least go back to what we were using until such time as the author has the ability to address the issue.

krocheck commented 2 years ago

Here's what I posted to Slack recently on the topic: "The core needs to get a fix to change image rendering when topbar is removed. I had a fix for the core that upon further review wasn't the correct approach but I've had no time in the months since to fix the core with that new approach to then fix the shure module. So it may not seem broken as is because it doesn't fire a blocking error, but its broken as is. And I do not have a timeline because I've been on the road for the last couple months and when I get home there's a family medial thing going on that will take whatever extra attention I have."

jsnyder886 commented 2 years ago

Thanks so much for the update. I'm sorry to hear of your family medical issue. Please don't mistake me, I am very grateful of your efforts, and please believe me when I tell you I am very sympathetic to the time constraints as they relate to volunteer work. I'm just an idea guy, and was looking for at least a temporary fix in the mean time. I do apologize if my comments earlier did not reflect that.

I hope your medical situation improves with time. Thank you again.

Jon

On Mon, Oct 18, 2021, 12:35 Keith Rocheck @.***> wrote:

Here's what I posted to Slack recently on the topic: "The core needs to get a fix to change image rendering when topbar is removed. I had a fix for the core that upon further review wasn't the correct approach but I've had no time in the months since to fix the core with that new approach to then fix the shure module. So it may not seem broken as is because it doesn't fire a blocking error, but its broken as is. And I do not have a timeline because I've been on the road for the last couple months and when I get home there's a family medial thing going on that will take whatever extra attention I have."

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-shure-wireless/issues/13#issuecomment-945956981, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQUCQYKKO6NW2BR76MEHVRTUHREG5ANCNFSM5GHA6PJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.