bitfocus / companion-module-songbeamer-osc

Songbeamer OSC Module
MIT License
5 stars 0 forks source link

Implement /xinfo and /info Feedbacks #20

Closed bensteUEM closed 1 year ago

bensteUEM commented 1 year ago

sending a OSC message without arguments a information object is expected as response and not received. If Songbeamer is following the XAir OSC protocoll the following messages are expected

/info

<string server_version>
<string server_name>
<string console_model>
<string console_version>

/xinfo

<string network address>
<string network name>
<string console_model>
<string console_version>
bensteUEM commented 1 year ago

/xinfo response debug: Received OSC message, Remote info is: {"address":"192.168.0.28","family":"IPv4","port":10023,"size":64}

/info response debug: OSC Content is: {"address":"/info","args":[{"type":"s","value":"V2.08"},{"type":"s","value":"osc-server"},{"type":"s","value":"SongBeamer"},{"type":"s","value":"6.00"}]}

-> not a bug - added logging to warn in case of not implemented actions

bensteUEM commented 1 year ago

style of response changed to include types

debug: Sent OSC to 192.168.0.28:10023 with /xinfo and []
debug: Received OSC message from: {"address":"192.168.0.28","family":"IPv4","port":10023,"size":64}
debug: OSC Content is: {"address":"/xinfo","args":[{"type":"s","value":"192.168.0.28"},{"type":"s","value":"osc-server"},{"type":"s","value":"SongBeamer"},{"type":"s","value":"6.04"}]}
warn: received a message with an unknown address - not implemented

in fact list of

debug: Sent OSC to 192.168.0.28:10023 with /info and []
debug: Received OSC message from: {"address":"192.168.0.28","family":"IPv4","port":10023,"size":56}
debug: OSC Content is: {"address":"/info","args":[{"type":"s","value":"V2.08"},{"type":"s","value":"osc-server"},{"type":"s","value":"SongBeamer"},{"type":"s","value":"6.04"}]}
warn: received a message with an unknown address - not implemented

list like

bensteUEM commented 1 year ago

No Feedback actions required because this is information is configured it the connection properties and only used upon init - there is no use case of e.g. a user variable referencing these values

See #32 for use with init